Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add support for TrafficManagerProfile and TrafficManagerProfileEndpoints #3326

Merged
merged 4 commits into from
Oct 2, 2023

Conversation

super-harsh
Copy link
Collaborator

Closes #1265

What this PR does / why we need it:
This PR adds support for TrafficManagerProfile, TrafficManagerProfilesNestedEndpoints, TrafficManagerProfilesAzureEndpoints, and TrafficManagerProfilesExternalEndpoints.

If applicable:

  • this PR contains documentation
  • this PR contains tests

@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2023

Codecov Report

Merging #3326 (b133ec8) into main (af615ca) will decrease coverage by 0.03%.
Report is 25 commits behind head on main.
The diff coverage is 51.29%.

@@            Coverage Diff             @@
##             main    #3326      +/-   ##
==========================================
- Coverage   54.52%   54.50%   -0.03%     
==========================================
  Files        1483     1511      +28     
  Lines      633484   634652    +1168     
==========================================
+ Hits       345437   345905     +468     
- Misses     231435   232133     +698     
- Partials    56612    56614       +2     
Files Coverage Δ
...ons/traffic_manager_profile_extension_types_gen.go 100.00% <100.00%> (ø)
...ger_profiles_azure_endpoint_extension_types_gen.go 100.00% <100.00%> (ø)
..._profiles_external_endpoint_extension_types_gen.go 100.00% <100.00%> (ø)
...er_profiles_nested_endpoint_extension_types_gen.go 100.00% <100.00%> (ø)
...v1api20220401/traffic_manager_profile_types_gen.go 55.27% <ø> (ø)
...2/internal/controllers/controller_resources_gen.go 86.11% <100.00%> (+0.26%) ⬆️
...220401/trafficmanagerprofile_spec_arm_types_gen.go 33.33% <33.33%> (ø)
...nagerprofiles_azure_endpoint_spec_arm_types_gen.go 33.33% <33.33%> (ø)
...erprofiles_external_endpoint_spec_arm_types_gen.go 33.33% <33.33%> (ø)
...agerprofiles_nested_endpoint_spec_arm_types_gen.go 33.33% <33.33%> (ø)
... and 7 more

... and 198 files with indirect coverage changes

tc.PatchResourceAndWait(old, tmp)
tc.Expect(tmp.Status.Tags).To(HaveKey("foo"))

tc.RunSubtests(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use parallelSubtests here? Or no?

@super-harsh super-harsh merged commit 2583722 into main Oct 2, 2023
@super-harsh super-harsh deleted the feature/trafficmanagerprofile branch October 2, 2023 09:44
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Feature: Support Traffic Manager Profiles and Traffic Manager Endpoints
3 participants