-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add support for Fleet #3336
Add support for Fleet #3336
Conversation
Add support for fleet
add crud test and generated subresources
Feature/fleet test
Codecov Report
@@ Coverage Diff @@
## main #3336 +/- ##
==========================================
- Coverage 54.51% 54.49% -0.02%
==========================================
Files 1483 1495 +12
Lines 628101 630865 +2764
==========================================
+ Hits 342408 343807 +1399
- Misses 229568 230696 +1128
- Partials 56125 56362 +237
|
6ecdbc8
to
da12744
Compare
46b4241
to
2c733ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks very good - I've found little to critique during my review. Fix up the $supportedFrom
setting and a couple other minor things and we can merge this.
v2/samples/containerservice/v1api20230315preview/v1api20230315preview_fleet.yaml
Outdated
Show resolved
Hide resolved
v2/samples/containerservice/v1api20230315preview/v1api20230315preview_fleetsmember.yaml
Outdated
Show resolved
Hide resolved
v2/samples/containerservice/v1api20230315preview/v1api20230315preview_fleetsupdaterun.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except a few some minor nits.
v2/samples/containerservice/v1api20230315preview/refs/v1api20230202preview_managedcluster.yaml
Outdated
Show resolved
Hide resolved
v2/samples/containerservice/v1api20230315preview/v1api20230315preview_fleet.yaml
Outdated
Show resolved
Hide resolved
v2/samples/containerservice/v1api20230315preview/v1api20230315preview_fleetsmember.yaml
Outdated
Show resolved
Hide resolved
v2/samples/containerservice/v1api20230315preview/v1api20230315preview_fleetsupdaterun.yaml
Outdated
Show resolved
Hide resolved
/ok-to-test sha=f693716 |
1 similar comment
/ok-to-test sha=f693716 |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
What this PR does / why we need it:
Add support for Fleet, FleetsMember, FleetsUpdateRun
Special notes for your reviewer:
How does this PR make you feel:

If applicable: