Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add support for Fleet #3336

Merged
merged 18 commits into from
Sep 28, 2023
Merged

Add support for Fleet #3336

merged 18 commits into from
Sep 28, 2023

Conversation

nibooy
Copy link
Contributor

@nibooy nibooy commented Sep 22, 2023

What this PR does / why we need it:
Add support for Fleet, FleetsMember, FleetsUpdateRun

Special notes for your reviewer:

How does this PR make you feel:
gif

If applicable:

  • this PR contains documentation
  • this PR contains tests

@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2023

Codecov Report

Merging #3336 (f693716) into main (40810e1) will decrease coverage by 0.02%.
The diff coverage is 58.45%.

@@            Coverage Diff             @@
##             main    #3336      +/-   ##
==========================================
- Coverage   54.51%   54.49%   -0.02%     
==========================================
  Files        1483     1495      +12     
  Lines      628101   630865    +2764     
==========================================
+ Hits       342408   343807    +1399     
- Misses     229568   230696    +1128     
- Partials    56125    56362     +237     
Files Coverage Δ
...ervice/customizations/fleet_extension_types_gen.go 100.00% <100.00%> (ø)
...ustomizations/fleets_member_extension_types_gen.go 100.00% <100.00%> (ø)
...mizations/fleets_update_run_extension_types_gen.go 100.00% <100.00%> (ø)
...1api20230315preview/fleets_update_run_types_gen.go 52.78% <ø> (ø)
...2/internal/controllers/controller_resources_gen.go 85.97% <100.00%> (+0.12%) ⬆️
...e/v1api20230315preview/fleet_spec_arm_types_gen.go 33.33% <33.33%> (ø)
...0230315preview/fleets_member_spec_arm_types_gen.go 33.33% <33.33%> (ø)
...315preview/fleets_update_run_spec_arm_types_gen.go 33.33% <33.33%> (ø)
...i20230315previewstorage/fleets_member_types_gen.go 52.72% <52.72%> (ø)
...30315previewstorage/fleets_update_run_types_gen.go 52.72% <52.72%> (ø)
... and 3 more

... and 32 files with indirect coverage changes

Copy link
Member

@theunrepentantgeek theunrepentantgeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very good - I've found little to critique during my review. Fix up the $supportedFrom setting and a couple other minor things and we can merge this.

Copy link
Member

@matthchr matthchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except a few some minor nits.

@theunrepentantgeek
Copy link
Member

/ok-to-test sha=f693716

1 similar comment
@theunrepentantgeek
Copy link
Member

/ok-to-test sha=f693716

@theunrepentantgeek
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@theunrepentantgeek theunrepentantgeek merged commit e3ba2c5 into Azure:main Sep 28, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

5 participants