-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Support setting the webhook port and cert dir in the Helm chart #3470
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adamdougal #3444 is for ASOv2 helm chart and the changes in your PR are for ASOv1 helm chart. We have ASOv2 helm chart here for which we generate files using task target controller:gen-helm-manifest
@super-harsh Dang, I missed the charts dir under |
@@ -84,8 +84,12 @@ flow_control "aadpodidbinding" "aadpodidbinding" "$IF_TENANT" "$GEN_FILES_DIR"/* | |||
flow_control "--enable-leader-election" "--enable-leader-election" "$IF_TENANT" "$GEN_FILES_DIR"/*_deployment_* | |||
|
|||
# TODO: This bit is tricky to exclude kube-rbac-proxy and webhook stuff. | |||
flow_control "serving-certs" "name: https" "$IF_CLUSTER" "$GEN_FILES_DIR"/*_deployment_* | |||
flow_control "mountPath: \/tmp\/k8s-webhook-server\/serving-certs" "name: https" "$IF_CLUSTER" "$GEN_FILES_DIR"/*_deployment_* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This had to be made more specific so not to clash with the new arg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution, this looks good to me. I've kicked off E2E testing to ensure that passes but from my examination of the resulting Helm chart it should.
As you highlighted, we will hold off publishing a new chart until we also publish a new container image (probably later this week).
/ok-to-test sha=3548499 |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov Report
@@ Coverage Diff @@
## main #3470 +/- ##
==========================================
- Coverage 54.32% 54.24% -0.08%
==========================================
Files 1566 1571 +5
Lines 655434 653199 -2235
==========================================
- Hits 356073 354351 -1722
+ Misses 241588 241283 -305
+ Partials 57773 57565 -208 |
Closes #3444
What this PR does / why we need it:
Provides the ability to set the webhook port and cert dir when deploying using the helm chart. These options were added in #3442.
Special notes for your reviewer:
How does this PR make you feel:

If applicable: