Controller should use HEAD if GET is not available #3530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthchr
requested review from
davefellows,
theunrepentantgeek,
babbageclunk and
super-harsh
as code owners
theunrepentantgeek
approved these changes
Nov 8, 2023
v2/internal/reconcilers/arm/azure_generic_arm_reconciler_instance.go
Outdated
Show resolved
Hide resolved
super-harsh
approved these changes
Nov 8, 2023
matthchr
added
the
microsoft.apimanagement
2 tasks
matthchr
force-pushed
the
feature/controller-use-head
branch
from
820a01f to
3b394f8
Compare
|
/ok-to-test sha=3b394f8 |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3530 +/- ##
==========================================
+ Coverage 52.91% 53.10% +0.19%
==========================================
Files 1285 1285
Lines 401910 401924 +14
==========================================
+ Hits 212666 213443 +777
+ Misses 158640 157874 -766
- Partials 30604 30607 +3 ☔ View full report in Codecov by Sentry. |
matthchr
force-pushed
the
feature/controller-use-head
branch
from
3b394f8 to
90da660
Compare
|
/ok-to-test sha=90da660 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #3398.
Note that there are no tests for this (yet), but they will come when we add the APIM resources which don't have a body (which will come in a future PR). I've already confirmed that these tests pass.
If applicable: