Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add Keyvault 2023-07-01 #3605

Merged
merged 4 commits into from
Nov 29, 2023
Merged

Add Keyvault 2023-07-01 #3605

merged 4 commits into from
Nov 29, 2023

Conversation

super-harsh
Copy link
Collaborator

@super-harsh super-harsh commented Nov 28, 2023

Closes #3217

What this PR does / why we need it:

Adding latest stable version(2023-07-01) for Microsoft/Keyvault

@super-harsh super-harsh self-assigned this Nov 28, 2023
@super-harsh super-harsh changed the title Add Keyvault 2022-07-01 Add Keyvault 2023-07-01 Nov 28, 2023
@codecov-commenter
Copy link

Codecov Report

Attention: 438 lines in your changes are missing coverage. Please review.

Comparison is base (f6ab7ee) 53.08% compared to head (7c612a6) 53.14%.
Report is 1 commits behind head on main.

Files Patch % Lines
...lt/v1api20210401preview/storage/vault_types_gen.go 63.56% 249 Missing and 162 partials ⚠️
.../keyvault/v1api20230701/storage/vault_types_gen.go 63.41% 13 Missing and 2 partials ⚠️
...i/keyvault/v1api20210401preview/vault_types_gen.go 50.00% 4 Missing and 4 partials ⚠️
...keyvault/v1api20230701/vault_spec_arm_types_gen.go 33.33% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3605      +/-   ##
==========================================
+ Coverage   53.08%   53.14%   +0.06%     
==========================================
  Files        1286     1289       +3     
  Lines      406699   409846    +3147     
==========================================
+ Hits       215894   217831    +1937     
- Misses     159804   160706     +902     
- Partials    31001    31309     +308     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@super-harsh super-harsh added this pull request to the merge queue Nov 29, 2023
Merged via the queue into main with commit d0cf807 Nov 29, 2023
@super-harsh super-harsh deleted the feature/stable-keyvault branch November 29, 2023 00:37
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Feature: Support for publicNetworkAccess property for keyvault.azure.com
3 participants