Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add Storage version 2023-01-01 #3613

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

matthchr
Copy link
Member

  • Also fix bug where validations were not being stripped for the AzureName property on storage versions.

If applicable:

  • this PR contains documentation
  • this PR contains tests

* Also fix bug where validations were not being stripped for the
  AzureName property on storage versions.
@codecov-commenter
Copy link

Codecov Report

Attention: 695 lines in your changes are missing coverage. Please review.

Comparison is base (f6ab7ee) 53.08% compared to head (355fbe5) 53.27%.
Report is 5 commits behind head on main.

Files Patch % Lines
...lt/v1api20210401preview/storage/vault_types_gen.go 63.84% 249 Missing and 161 partials ⚠️
...181130/storage/user_assigned_identity_types_gen.go 56.08% 89 Missing and 41 partials ⚠️
...storage/federated_identity_credential_types_gen.go 46.07% 77 Missing and 33 partials ⚠️
.../keyvault/v1api20230701/storage/vault_types_gen.go 62.79% 14 Missing and 2 partials ⚠️
...i/keyvault/v1api20210401preview/vault_types_gen.go 50.00% 4 Missing and 4 partials ⚠️
.../v1api20181130/user_assigned_identity_types_gen.go 50.00% 4 Missing and 4 partials ⚠️
...preview/federated_identity_credential_types_gen.go 50.00% 4 Missing and 4 partials ⚠️
...keyvault/v1api20230701/vault_spec_arm_types_gen.go 33.33% 4 Missing ⚠️
...compute/v1api20220301/virtual_machine_types_gen.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3613      +/-   ##
==========================================
+ Coverage   53.08%   53.27%   +0.18%     
==========================================
  Files        1286     1325      +39     
  Lines      406699   433031   +26332     
==========================================
+ Hits       215894   230683   +14789     
- Misses     159804   168469    +8665     
- Partials    31001    33879    +2878     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthchr
Copy link
Member Author

/ok-to-test sha=355fbe5

@matthchr
Copy link
Member Author

/ok-to-test sha=355fbe5

1 similar comment
@matthchr
Copy link
Member Author

/ok-to-test sha=355fbe5

@theunrepentantgeek theunrepentantgeek added this pull request to the merge queue Nov 30, 2023
Merged via the queue into Azure:main with commit 7f4298d Nov 30, 2023
@theunrepentantgeek theunrepentantgeek deleted the feature/storage-update branch November 30, 2023 09:22
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

4 participants