Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Adding gif section in PR template #364

Merged
merged 1 commit into from
Oct 15, 2019
Merged

Adding gif section in PR template #364

merged 1 commit into from
Oct 15, 2019

Conversation

melonrush13
Copy link
Contributor

@melonrush13 melonrush13 commented Oct 15, 2019 •
edited
Loading

Adding giphy integration : )

Instructions on how to add gif

  1. Go to giphy
  2. Find a high quality gif
  3. Copy gif link
  4. paste URL in url section under "how does this make you feel?"

ex:
![name of gif](url here)

noice

If applicable:

  • this PR contains documentation
  • this PR contains tests

frodopwns
frodopwns approved these changes Oct 15, 2019
View reviewed changes
Copy link
Contributor

@frodopwns frodopwns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@melonrush13 melonrush13 merged commit da7916c into Azure:master Oct 15, 2019
Porges pushed a commit that referenced this pull request May 11, 2021
@theunrepentantgeek
Improve pluralization of type names (#364)
44e6e05 
* Extend manual fixes for pluralization

* Implement Stringer on PropertyDefinition
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@frodopwns frodopwns frodopwns approved these changes

@ultimateboy ultimateboy Awaiting requested review from ultimateboy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@melonrush13 @frodopwns