Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Contributing: arm64 support #3687

Merged
merged 13 commits into from
Jan 12, 2024
Merged

Contributing: arm64 support #3687

merged 13 commits into from
Jan 12, 2024

Conversation

mehighlow
Copy link
Contributor

What this PR does / why we need it:

  • This PR fixes issues with packages for ARM64 architecture
  • Updates azwi as macOS arm64 support has been introduced starting version 1.1.0
  • Formats documentation

@ManuInNZ
Copy link

ManuInNZ commented Jan 6, 2024

not really related but as I saw the macos arm64 and cross plane, I am trying my luck.

is there more details or content to explore/use the crossplane hack?

cheers

@mehighlow
Copy link
Contributor Author

not really related but as I saw the macos arm64 and cross plane, I am trying my luck.

is there more details or content to explore/use the crossplane hack?

cheers

IDK, frankly speaking. It is better to ask this in the #azure-service-operator channel on the Kubernetes Slack

@mehighlow mehighlow requested a review from super-harsh January 10, 2024 04:29
matthchr
matthchr approved these changes Jan 11, 2024
View reviewed changes
Copy link
Member

@matthchr matthchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one minor nit.

@ManuInNZ
Copy link

not really related but as I saw the macos arm64 and cross plane, I am trying my luck.

is there more details or content to explore/use the crossplane hack?

cheers

IDK, frankly speaking. It is better to ask this in the #azure-service-operator channel on the Kubernetes Slack

thanks

@matthchr
Copy link
Member

/ok-to-test sha=0e6d382

@matthchr
Copy link
Member

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@matthchr
Copy link
Member

/ok-to-test sha=068d1a7

@matthchr
Copy link
Member

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@matthchr matthchr added this pull request to the merge queue Jan 12, 2024
Merged via the queue into Azure:main with commit 89bd8ac Jan 12, 2024
9 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@matthchr matthchr matthchr approved these changes

@davefellows davefellows Awaiting requested review from davefellows davefellows is a code owner

@theunrepentantgeek theunrepentantgeek Awaiting requested review from theunrepentantgeek theunrepentantgeek is a code owner

@babbageclunk babbageclunk Awaiting requested review from babbageclunk babbageclunk is a code owner

@super-harsh super-harsh Awaiting requested review from super-harsh super-harsh is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Azure Service Operator Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mehighlow @ManuInNZ @matthchr @super-harsh