Create Terraform AKS helper #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also changed the default location to westus2
jananivMS
previously requested changes
Oct 24, 2019
…or into terraform-helper # By Anna Zietlow (8) and others # Via GitHub (6) and Anna Zietlow (3) * 'master' of github.com:jakiefermsft/azure-service-operator: add tests for controller with mock (#344) Revert "Revert "Replace hard coded event types in calls to Recorder with consts "" Revert "Replace hard coded event types in calls to Recorder with consts " Adding aso types (#411) Fixed the SQL Firewall Requeue issue (#409) Telemetry (#401) Update consts in Azure SQL controller finalizer update a few missed replacements update strings to const in resourcegroup and storage controllers update event type strings to consts in keyvault and redis controllers update event type strings to const for eventhubnamespace controller replace event type strings to consts for eventhub controller update event type to consts in cosmosdb controller update event types to consts for consumer group controller # Conflicts: # Makefile
frodopwns
reviewed
Oct 30, 2019
frodopwns
reviewed
Oct 30, 2019
frodopwns
approved these changes
Oct 30, 2019
… terraform-helper * 'master' of github.com:Azure/azure-service-operator: Update KeyVaultStatus fields, KeyVault Controller Cleaning (#415) removing unused fields cleaning up comments comment and log message cleanup use constants for event type remove commented code rename azure client 'Az' to 'AzureClient' fix issues in rg pkg tests resulting from async delete change flesh out mock to work with async operator working on improcing status working on getting tests to pass update test clients to match interface whoops leftover debug code add logs to resourcegroup client, remove wiat from rg delete working on robustness working on implementing a more generic interface/reconcile stragegy feat: semi-generic async azure controller + CLI improvements feat: implement keyvault secret, bundle, additional controllers chore: secrets work
Co-Authored-By: Erin Corson <frodopwns@gmail.com>
jananivMS
reviewed
Nov 1, 2019
| terraform init devops/terraform | ||
| terraform apply devops/terraform | ||
|
|
||
| terraform-and-deploy: terraform generate install-cert-manager build-and-push deploy |
There was a problem hiding this comment.
This still has some issues like when the command fails once (in my case since my docker login wasnt set), the next time it fails as install-cert-manager is not idempotent. So there would still be some limitations to use this like you may need to do a terraform destroy before running again
There was a problem hiding this comment.
Would a make delete work?
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Spinning up an AKS cluster for testing is time consuming and this automates the entire process. Just run a
make terraform-and-deploy, supply a couple tokens and get a ☕️.If applicable: