Creating a central Status Struct #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Noticed you didn't apply the central status struct to keyvault. I assume this is because it follows a different pattern / is in prod so we don't want to mess it up but just wanted to confirm it wasn't an oversight. |
|
Yes, @clmccart! Exactly. It followed a different pattern so I made a new issue for it here #413 (KeyVault had an additional ID value in the status struct which is being used in the controller and tests, so I'm handling them in a new branch right now. Once that is resolved, we will use the ASOStatus there, too!) |
clmccart
reviewed
Oct 24, 2019
clmccart
approved these changes
Oct 24, 2019
|
Thank you @clmccart :) |
2 tasks
Porges
pushed a commit
that referenced
this pull request
May 11, 2021
* Preallocate sufficient room for sanitizing the package name * Use v1alpha1api as prefix for API versions * Add IsPreview to PackageReference * Update receiver names * Add tests for IsPreview() * Update tests * Use smart cast in pipeline stage. * Add sorting for package references * Fix version numbers in configuration files * Update paths used in tests * Fix panic caused by nil deployment value * Move files to new namespace * Update another version reference * Uncomment version filters * Update version numbers * Rename file to remove _gen suffix * Revert receiver renames * Use titlecase when creating versioned package imports * Improve doc comments * Fix unit tests for titlecase change * Change order of imports * Revert capitalization of version numbers * Use local variables to simplify code * Reuse implementation of IsPreview() * Fix strange import * Simplify helper method containsPreviewVersionLabel and consumption
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #406
What this PR does / why we need it:
Special notes for your reviewer:
How does this PR make you feel:
If applicable: