Allow importing of FrontDoor resources #4262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theunrepentantgeek
requested review from
davefellows,
matthchr,
babbageclunk and
super-harsh
as code owners
matthchr
approved these changes
Sep 13, 2024
|
It sounds like the user that reported this tested it and it helped but there was some other issue with importing routes, may be worth looking at that too |
matthchr
approved these changes
Sep 16, 2024
| * Licensed under the MIT license. | ||
| */ | ||
|
|
||
| package importresources |
There was a problem hiding this comment.
minor: Could be importresources_test, I think?
Cleaner as it avoids the temptation to test internals (which is sometimes what you want to do but sometimes not desirable).
There was a problem hiding this comment.
I'll move it, but really prefer to keep things close unless there's a problem (like a circular reference) that can be resolved by using the test package naming.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When scanning for child/extension resources in the
cdngroup,asoctlruns into aNoRegisteredProviderFounderror which is incorrectly treated as a fatal error.Changing this to a known case, where we simply skip the check for that particular kind of child resource, results in the import working correctly.
Closes #4260
How does this PR make you feel:
