Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Reduce noise when importing PostgreSQL Flexible Server Configurations #4279

Merged
merged 3 commits into from
Sep 18, 2024
Merged

Reduce noise when importing PostgreSQL Flexible Server Configurations #4279

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9755099
Code gardening
theunrepentantgeek Sep 18, 2024
554ed96
Filter out readonly configuration
theunrepentantgeek Sep 18, 2024
a128401
Filter out default values
theunrepentantgeek Sep 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion v2/api/dbforpostgresql/customizations/flexible_servers_configuration_extensions.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,23 @@ func (extension *FlexibleServersConfigurationExtension) Import(
// API version in the generator.)
if config, ok := rsrc.(*api.FlexibleServersConfiguration); ok {
// Skip system defaults
if config.Spec.Source != nil && *config.Spec.Source == "system-default" {
if config.Spec.Source != nil &&
*config.Spec.Source == "system-default" {
return extensions.ImportSkipped("system-defaults don't need to be imported"), nil
}

// Skip readonly configuration
if config.Status.IsReadOnly != nil &&
*config.Status.IsReadOnly {
return extensions.ImportSkipped("readonly configuration can't be set"), nil
}

// Skip default values
if config.Status.DefaultValue != nil &&
config.Status.Value != nil &&
*config.Status.DefaultValue == *config.Status.Value {
return extensions.ImportSkipped("default value is the same as the current value"), nil
}
}

return result, nil
Expand Down
Loading