Add support for 2024-09-01 version of AKS API #4419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthchr
requested review from
davefellows,
theunrepentantgeek,
babbageclunk and
super-harsh
as code owners
v2/tools/generator/internal/codegen/pipeline/strip_descriptions.go
Outdated
Show resolved
Hide resolved
theunrepentantgeek
approved these changes
Nov 6, 2024
|
I've changed how I stripped descriptions to make it a configuration option in |
- Fix issue in RepairSkippingProperties which could cause an issue when a type is reused among multiple resources, such as in a containerservice ManagedCluster and AgentPool. - Add new StripDocumentation pipeline stage, which can be used to strip descriptions off CRD types to reduce their size. - We don't want to do this in perpetuity, see Azure#4418 which tracks removing some old versions of ManagedCluster so we can drop this in a future release. - Add support for 2024-09-01 version of AKS API. - Add support for MaintenanceConfiguration.
matthchr
force-pushed
the
feature/update-mc
branch
from
e3a0f49 to
43d8b2a
Compare
|
/ok-to-test sha=43d8b2a |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
RepairSkippingPropertieswhich could cause an issue when a type is reused among multiple resources, such as in a containerservice ManagedCluster and AgentPool.StripLargeDescriptionspipeline stage, which can be used to strip descriptions off CRD types to reduce their size.Fixes #4164.
Fixes #4327.