Fix "missing error information" error on 409s #4530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can happen if the Azure RP being called returns a JSON error response payload that doesn't match the Azure contract. Instead of overwriting the underlying error, just return it as-is to aid in debugging.
matthchr
requested review from
davefellows,
theunrepentantgeek,
babbageclunk and
super-harsh
as code owners
|
/ok-to-test sha=ca6ddee |
Comment on lines
+72
to
+75
| // error shape contract. The good news is that if this happens we know this isn't | ||
| // an unregistered RP because that API will have the right shape. We just return | ||
| // the resp/err directly in this case to let the caller deal with whatever the problem | ||
| // was as we know it wasn't unregistered RP. |
There was a problem hiding this comment.
I don't understand this - it appears to be saying that we know this is a registered RP because those have the right shape, but isn't the problem here due to the result having the wrong shape?
There was a problem hiding this comment.
What I'm trying to say is, the error for unregistered RP will have the correct shape. So if we end up in this if (incorrect shape), it had to come from the RP, which means its registered, which means we can just return the error as-is we don't need to try to parse/process it.
theunrepentantgeek
approved these changes
Jan 16, 2025
super-harsh
approved these changes
Jan 17, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 17, 2025
This can happen if the Azure RP being called returns a JSON error response payload that doesn't match the Azure contract. Instead of overwriting the underlying error, just return it as-is to aid in debugging.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can happen if the Azure RP being called returns a JSON error response payload that doesn't match the Azure contract. Instead of overwriting the underlying error, just return it as-is to aid in debugging.