Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Option 2 for catching async errors in sql server creation #873

Merged
merged 10 commits into from
Apr 3, 2020
Merged

Option 2 for catching async errors in sql server creation #873

merged 10 commits into from
Apr 3, 2020

Conversation

frodopwns
Copy link
Contributor

@frodopwns frodopwns commented Apr 3, 2020 •
edited
Loading

Closes #400

  • adds polling url to status
  • creates a client to call the polling url and handle its response
  • checks polling url on 404 when the server appears to be provisioning
  • fails provisioning when async error has occurred

jskulavik
jskulavik suggested changes Apr 3, 2020
View reviewed changes
Copy link
Contributor

@jskulavik jskulavik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we can promote the pollClient to a shared package.

@frodopwns frodopwns mentioned this pull request Apr 3, 2020
Closed
@jskulavik jskulavik self-requested a review April 3, 2020 20:02
jskulavik
jskulavik approved these changes Apr 3, 2020
View reviewed changes
Copy link
Contributor

@jskulavik jskulavik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it looks GREAT to me.

@frodopwns frodopwns merged commit 2583d4d into Azure:master Apr 3, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jskulavik jskulavik jskulavik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@frodopwns @jskulavik