Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Enable Multi Region Writes for CosmosDB #954

Merged
merged 6 commits into from
Apr 21, 2020
Merged

Enable Multi Region Writes for CosmosDB #954

merged 6 commits into from
Apr 21, 2020

Conversation

melonrush13
Copy link
Contributor

Closes #921

What this PR does / why we need it:

  • Adds enableMultipleWriteLocations bool to the yaml file for users to have the option to enable multi region writes when provisioning a cosmos DB
  • Also adjusted the CreateOrUpdateCosmosDB parameters to include properties for nested values instead of adding them individually (for enableMultipleWriteLocations and DatabaseAccountOfferType specfically) @jpflueger hope this is okay :)

Special notes for your reviewer:

  • Create a CosmosDB with enableMultipleWriteLocations = true
  • Go to Azure, and click on "Replicate data globally" setting on CosmosDB instance
  • Should be toggled to true

Screen Shot 2020-04-16 at 4 51 42 PM

How does this PR make you feel:
gif

If applicable:

  • this PR contains documentation
  • this PR contains tests

Copy link
Contributor

@jpflueger jpflueger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jpflueger jpflueger merged commit e67b110 into Azure:master Apr 21, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Task: CosmosDB: enable multi-region writes
2 participants