Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Adding Fields to Kubectl Get (Message and Provisioned) #968

Merged
merged 2 commits into from
Apr 21, 2020
Merged

Adding Fields to Kubectl Get (Message and Provisioned) #968

merged 2 commits into from
Apr 21, 2020

Conversation

melonrush13
Copy link
Contributor

@melonrush13 melonrush13 commented Apr 20, 2020

Closes #410

What this PR does / why we need it:
Adds custom fields to kubectl get (instead of the default of age.)

Looks like this:

NAME                                    PROVISIONED   MESSAGE
resourcegroup-azure-operators-lem       true          successfully provisioned
resourcegroup-azure-operators-mel       true          successfully provisioned
resourcegroup-azure-operators-testtwo   true          successfully provisioned

Special notes for your reviewer:
Do a kubectl get on any resource and observe the fields at the top. Should list Name, Provisioned, and Message

How does this PR make you feel:
gif

If applicable:

  • this PR contains documentation
  • this PR contains tests

@frodopwns frodopwns requested a review from jananivMS April 21, 2020 16:28
@melonrush13
Copy link
Contributor Author

melonrush13 commented Apr 21, 2020

Created a new issue #973 for adding shortname. We will keep this PR scoped to only adding the new fields of message and provisioned for a k get.

Copy link
Contributor

@jananivMS jananivMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. tested in progress, on completion, failed provisioning etc.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Task: improve kubectl get output for CRDs by adding status fields
2 participants