Vnet provision -> false #980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CosmosDB test region workaround (#896)
reset failed provisioning in case the outcome changes
WilliamMortlMicrosoft
added
enhancement
high-priority
melonrush13
reviewed
Apr 23, 2020
melonrush13
previously approved these changes
Apr 23, 2020
2 tasks
|
Feel free to merge, @WilliamMortlMicrosoft ! Created an issue and PR for this bug I found here :) #996 |
| } | ||
| catchUnrecoverableErrors := []string{ | ||
| errhelp.NetcfgInvalidIPAddressPrefix, | ||
| errhelp.NetcfgInvalidSubnet, | ||
| errhelp.NetcfgInvalidVirtualNetworkSite, | ||
| errhelp.InvalidCIDRNotation, | ||
| errhelp.InvalidRequestFormat, | ||
| errhelp.InvalidAddressPrefixFormat, |
There was a problem hiding this comment.
@melonrush13 added the error here! :-)
melonrush13
approved these changes
Apr 23, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #709
closes #997
Sets provisioning to false when the vnet creation process hasnt started and there's a requeue
Also implements the FailedProvisioning flag properly for when ending reconciliation due to failure
Gif is in honor of Max who continues to improve :-)