-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Couple issues with 1.21.0 version #5443
Comments
Hi @juanmanuelpuhl, thank you for filing these 2 issues with the details and version. We are currently looking into both of these and get back to you shortly. |
@juanmanuelpuhl We have fixes for the first 2 issues you found in this #5448. These fixes will be part of our next release for 1.22.0-beta.1 and 1.22.0. |
@mgamis-msft thank you for the update. Regarding the captions, yes. I'm doing Teams interop with a Teams user |
@juanmanuelpuhl The user might not have the capability to set caption language at times. Could you add a listener to your adapter when you create it to log the
The object we are trying to log is of type:
If the Do you have access to your Teams admin center? Something worth double-checking is this following meeting setting: |
Thanks @mgamis-msft . I'll be checking that today and let you know |
Hi @mgamis-msft sorry for the delay, I have some results: regarding Teams admin center, the setting is the same as you shared in the screenshot. {
isPresent: false,
reason: "TeamsPremiumLicenseRestricted"
} after a few extra seconds it changes to {
isPresent: true,
reason: "Capable"
} and finally when the teams user joins, it changes back to {
isPresent: false,
reason: "TeamsPremiumLicenseRestricted"
} If the acs user then reloads the page while the Teams user remains there, the changes are: |
Thanks for sharing the logs and the timeline of this issue @juanmanuelpuhl. Our captions engineer is currently taking a deep look at this issue and we'll let you know the cause and the fix for it. |
Hi @juanmanuelpuhl , When you indicated |
Hi @juanmanuelpuhl, We have a fix incoming! You can learn more about Teams Premium licensing here: Microsoft Teams Premium Licensing Thank you for filing this issue! We will provide updates on the status of the fix and when to expect it in a future comment! |
Thanks for the response @edwardlee-msft
The process was the same, yes. The ACS user joins, but as the call is not started, he stays in the lobby until the Teams user joins. I haven't tried again in older versions, but I remember I was able to change the captions language.
Nice, thanks. Will this change hide the captions language selector when the user doesn't have the capability? I was able to hide it from my custom component, but haven't seen a way to hide it in the modal that is opened when using the three dots in the captions container. I mean here |
Thank you for confirming @juanmanuelpuhl . As for the caption language dropdown, that's a good call out! We have an active work-item to hide the dropdown in our modal when it's not available. One of our engineers is actively working to deliver it to our future release soon. We will keep this issue open until we have these changes available in one our public releases. |
Hi, I recently updated to latest version
1.21.0
and I'm seeing a couple errors. Also I need help with the captions feature.Issues:
"Captions will appear in this langugage."
Regarding closed captions. I made my own captions settings modal, to be able to set the spoken language and the captions language. I followed some of the code you are already using in the call composite, but sometimes I see an error when trying to set a caption language:
Call.feature: Set caption language failed. Teams premium license is needed to use this feature.
The message seems clear, but what I don't understand is that if I refresh the page, and try again, the message doesn't appear and the caption language is set accordingly. I've never seen this happening in previous versions (we imported the modal directly then).
What I'm doing to get the data we need is:
I'm not sure if there's something I need to take into account, or initialize before start using this feature.
Some data of the libraries:
The text was updated successfully, but these errors were encountered: