Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Evaluate System.Text.Json satisfies all mutation needs to be able to replace NewtonSoft.Json #60

Open
mbhaskar opened this issue Oct 8, 2021 · 2 comments
Assignees

Comments

@mbhaskar
Copy link
Member

mbhaskar commented Oct 8, 2021

System.Text.Json seems to have limited abilities in terms of writing/creating a JsonDocument. So we need migrate the runtime to use Newtonsoft.Json instead of System.Text.Json to achieve the relevant functionalities like creating JArray with elements etc.

@jarupatj jarupatj added this to the M0 milestone Nov 2, 2021
@seantleonard
Copy link
Contributor

Hi @mbhaskar , can you include a few references to project code or examples of where System.Text.Json is limited? I see a lot of docs that highly suggest migrating to System.Text.Json and would like to make sure we don't unnecessarily move to Newtonsoft. You mention 'JArray with elements,' and wondering what advantages you see there over JsonDocument.

@JelteF
Copy link
Contributor

JelteF commented Jan 14, 2022

As discussed over chat. We should first try the JsonNode API from System.Text.Json:
https://docs.microsoft.com/en-us/dotnet/api/system.text.json.nodes.jsonnode?view=net-6.0

@JelteF JelteF added the cleanup label Jan 14, 2022
@Aniruddh25 Aniruddh25 modified the milestones: M0, M1 Feb 10, 2022
@Aniruddh25 Aniruddh25 changed the title Migrate the runtime to use Newtonsoft.Json instead of System.Text.Json Evaluate System.Text.Json satisfies all mutation needs to be able to replace NewtonSoft.Json Apr 16, 2022
@Aniruddh25 Aniruddh25 modified the milestones: M1, M1.5 Apr 22, 2022
@Aniruddh25 Aniruddh25 removed this from the Open Sourcing Milestone milestone Feb 23, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

5 participants