Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix builds failing for catch2 v3.8 by using specified cmake version #702

Merged
merged 2 commits into from
Feb 27, 2025

Conversation

AndreRicardo-Zoetis
Copy link
Contributor

@AndreRicardo-Zoetis AndreRicardo-Zoetis commented Feb 27, 2025

Fix

CMake Error at CMakeLists.txt:1 (cmake_minimum_required):
  CMake 3.16 or higher is required.  You are running version 3.13.4

As mentioned on #689 (comment)

The combination of PR Migrate catch2 v2 to v3 #683 and Public GitHub Actions for build and test #689 sees that Debian 10 is using the system version of cmake 3.13.4 that is lower than the required by catch2 v3.8, which is cmake 3.16 https://github.com/catchorg/Catch2/blob/v3.8.0/CMakeLists.txt#L1

Tested on
https://github.com/AndreRicardo-Zoetis/iot-hub-device-update/actions/runs/13564853498/job/37915573097

Also tested locally with

scripts/install-deps.sh --install-aduc-deps --install-do --install-shellcheck

--install-aduc-deps sets install_catch2=true, so it also calls the install catch2.

PS: also fixed what I believe is a typo on the name of a variable for shellcheck version.

@jw-msft
Copy link
Contributor

jw-msft commented Feb 27, 2025

thanks, I'm doing a run of this in gh codespace

@jw-msft jw-msft self-requested a review February 27, 2025 20:45
@jw-msft jw-msft merged commit b1a33b0 into Azure:develop Feb 27, 2025
1 check passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants