Fix builds failing for catch2 v3.8 by using specified cmake version #702
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
As mentioned on #689 (comment)
The combination of PR Migrate catch2 v2 to v3 #683 and Public GitHub Actions for build and test #689 sees that Debian 10 is using the system version of cmake 3.13.4 that is lower than the required by catch2 v3.8, which is cmake 3.16 https://github.com/catchorg/Catch2/blob/v3.8.0/CMakeLists.txt#L1
Tested on
https://github.com/AndreRicardo-Zoetis/iot-hub-device-update/actions/runs/13564853498/job/37915573097
Also tested locally with
--install-aduc-deps
setsinstall_catch2=true
, so it also calls the install catch2.PS: also fixed what I believe is a typo on the name of a variable for shellcheck version.