Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Streaming ingestion and max file size #28

Open
i3arnon opened this issue Jun 25, 2019 · 2 comments
Open

Streaming ingestion and max file size #28

i3arnon opened this issue Jun 25, 2019 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@i3arnon
Copy link
Contributor

i3arnon commented Jun 25, 2019

The Java client will support streaming ingestion in the near future.
This allows this plugin to support it as well.
So, we can add an optional configuration for streaming.

However, streaming has a size cap (4mb), which AFAIK the plugin doesn't yet have.
So, I suggest also adding an optional configuration for max file size, which when reached creates a new file with some suffix and when streaming would be turned on that max size will be be the min of the request max size and 4mb.

@tamirkamara WDYT?

@danield137 danield137 added the enhancement New feature or request label Jun 25, 2019
@tamirkamara
Copy link
Contributor

tamirkamara commented Jul 12, 2019

@i3arnon
I think that is a possibility, although I'm not sure how you'll keep watch over the file size and know which suffix to add to each event...
Remember that currently the rolling mechanism is based on the event time and some events might get processed by the output plugin later despite them having an earlier timestamp.

Depending on the effort you plan to invest here, perhaps think about using java streams which should give better e2e performance for the streaming ingestion scenario.
What do you think?

@vladikbr
Copy link
Contributor

Taken as a feature request.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants