[macsecorch]: Support for non-default sa per sc #2250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Pterosaur
previously approved these changes
May 3, 2022
|
/Azp Azure.sonic-swss |
|
Command 'Azure.sonic-swss' is not supported by Azure Pipelines. Supported commands
See additional documentation. |
|
/Azp run Azure.sonic-swss |
|
/Azp rAzure.sonic-swss |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Command 'rAzure.sonic-swss' is not supported by Azure Pipelines. Supported commands
See additional documentation. |
|
/Azp run Azure.sonic-swss |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
judyjoseph
previously approved these changes
May 5, 2022
Pterosaur
pushed a commit
to sonic-net/sonic-wpa-supplicant
that referenced
this pull request
May 6, 2022
Adding code to query MACSEC_PORT_TABLE max_sa_per_sc in STATE_DB. In PR sonic-net/sonic-swss#2250 MacsecOrch will publish the max_sa_per_sc in STATE_DB. If we don't find the max_sa_per_sc we will default to 4 for max sa per sc. Max sa per sc is used to determine which AN values can be used during rekey. If a non-default max sa per sc is specified we will use the max value for rekey server priority. Infra fix in sonic_operators.cpp. -get function was extracting value incorrectly. -pair_count wasn't getting incremented per pair. Signed-off-by: Nathan Wolfe nwolfe@arista.com
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Please try to rebase it to the latest master branch for fixing the vstest fail. |
Querying max_sa_per_sc from SAI and storing in STATE_DB. If the SAI_MACSEC_ATTR_MAX_SECURE_ASSOCIATION_PER_SC is not supported we will use the default of 4. Signed-off-by: Nathan Wolfe <nwolfe@arista.com>
arista-nwolfe
force-pushed
the
master-max-sa-per-sc
branch
from
8e667ea to
950508b
Compare
Pterosaur
approved these changes
May 18, 2022
6 tasks
preetham-singh
pushed a commit
to preetham-singh/sonic-swss
that referenced
this pull request
Aug 6, 2022
What I did Taught MacsecOrch to use the SAI_MACSEC_ATTR_MAX_SECURE_ASSOCIATIONS_PER_SC attribute added in opencomputeproject/SAI#1420 Why I did it To support SAI_MACSEC_ATTR_MAX_SECURE_ASSOCIATIONS_PER_SC in MacsecOrch. How I verified it The changes have no impact until SAI_MACSEC_ATTR_MAX_SECURE_ASSOCIATIONS_PER_SC is supported by the platform. Details Cache the the result of SAI_MACSEC_ATTR_MAX_SECURE_ASSOCIATIONS_PER_SC in MACsecObject.m_max_sa_per_sc. Set STATE_DB MACSEC_PORT_TABLE's max_sa_per_sc to the value cached in MACsecObject.m_max_sa_per_sc in createMACsecPort. Signed-off-by: Nathan Wolfe <nwolfe@arista.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Taught MacsecOrch to use the SAI_MACSEC_ATTR_MAX_SECURE_ASSOCIATIONS_PER_SC attribute added in
opencomputeproject/SAI#1420
Why I did it
To support SAI_MACSEC_ATTR_MAX_SECURE_ASSOCIATIONS_PER_SC in MacsecOrch.
How I verified it
The changes have no impact until SAI_MACSEC_ATTR_MAX_SECURE_ASSOCIATIONS_PER_SC is supported by the platform.
Details
Cache the the result of SAI_MACSEC_ATTR_MAX_SECURE_ASSOCIATIONS_PER_SC in MACsecObject.m_max_sa_per_sc.
Set STATE_DB MACSEC_PORT_TABLE's max_sa_per_sc to the value cached in MACsecObject.m_max_sa_per_sc in createMACsecPort.