[Bug] ARM Library: Patch does not generate Updatable model for complex envelope types

[allenjzhang]

Describe the bug
Seeing one onboarding team hitting PatchBodyParametersSchema lintDiff. The root cause is this resource includes ManagedServiceIdentity from common type definition which type property is marked as required. Our auto update model generation does not seem to extend to the common types but still $ref to its original definition. As original definition contains required properties thus triggering this warning.

To Reproduce
Playground

Expected behavior
In update model, as we are starting to master the properties in TypeSpec models, we should stop generating $ref to original common definitions but generate an update model locally.

[markcowl]

Here is one solution that teams can use until this is fixed

[konrad-jamrozik]

Here is a discussion about PatchBodyParameterSchema rule:

• Review new behavior of the LintDiff PatchBodyParameterSchema rule azure-sdk-tools#7771

@allenjzhang @mikeharder FYI

[petrkotas]

Hi @markcowl thank you for the solution, I have tried in the PR https://github.com/Azure/azure-rest-api-specs-pr/pull/18316. Unfortunately without luck. I have two properties HcpOpenShiftClusterResource and HcpOpenShiftNodePoolResource, I tried to apply the variant as is proposed here for HcpOpenShiftClusterNodepoolResource, it game me additional error of identity not in the right place. For both resources, the original error PatchBodyParameterSchema remained.

May I ask for further suggestions?

[markcowl]

@petrkotas sent a PR to your branch with a fix

[markcowl]

Fixed.