[Bug]: New model UserAssignedIdentities
will cause breaking changes for SDK
#824
Closed
4 tasks done
Labels
bug
Something isn't working
lib:tcgc
Issues for @azure-tools/typespec-client-generator-core library
needs-area
Describe the bug
In 0.42, tsp-arm seems to introduce a new model
UserAssignedIdentities
:typespec-azure/packages/typespec-azure-resource-manager/lib/common-types/managed-identity.tsp
Line 37 in ac594eb
though previously, it's a property whose type is defined as
Record
:typespec-azure/packages/typespec-azure-resource-manager/lib/arm.foundations.tsp
Line 398 in 4c7a78a
TCGC will generate a new model
UserAssignedIdentities
if it's definedis Record
, which changes Java's generatedManagedServiceIdentity
'suserAssignedIdentities
property type fromMap<String, UserAssignedIdentity>
to nowUserAssignedIdentities
. This a breaking change. See Azure/autorest.java#2698 (comment)I wonder why we decide to change the
UserAssignedIdenties
definition?BTW, isn't
model is Record
discouraged in ARM?https://azure.github.io/typespec-azure/docs/libraries/azure-resource-manager/rules/no-record#-incorrect-1
Reproduction
It happens for SDK generation. In Swagger, it refers to the common model.
Checklist
The text was updated successfully, but these errors were encountered: