Skip to content
This repository has been archived by the owner on Jun 30, 2023. It is now read-only.

ADAL should not suggest to use *SerializeMsalV3 exclusively #1593

Closed
bgavrilMS opened this issue May 3, 2019 · 1 comment
Closed

ADAL should not suggest to use *SerializeMsalV3 exclusively #1593

bgavrilMS opened this issue May 3, 2019 · 1 comment
Milestone
5.0.5

Comments

@bgavrilMS
Copy link
Member

Which Version of ADAL are you using ?
ADAL 5.0.4

Which platform has the issue?
net45

Repro

  1. Write custom serialization
  2. Comments on the serialization methods, including on Serialize(), Deserialize(), all suggest users to use

SerializeMsalV3 and DeserializeMsalV3

Actual: These APIs do not save ATs and IDTs. This is by design, because only RTs can be used across v1 and v2 endpoints

Impact: Because ATs are not persisted, they will be requested every time from AAD, causing slowness in the app and high load on AAD.
@bgavrilMS bgavrilMS mentioned this issue May 3, 2019
Merged
@bgavrilMS bgavrilMS changed the title ADAL should not suggest to use *SerializeMsalV3 ADAL should not suggest to use *SerializeMsalV3 exclusively May 3, 2019
@jennyf19 jennyf19 added this to the 5.0.5 milestone May 3, 2019
@jennyf19
Copy link
Contributor

jennyf19 commented May 3, 2019

fixed in adal 5.0.5

@jennyf19 jennyf19 closed this as completed May 3, 2019
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.0.5
Development

No branches or pull requests
2 participants
@bgavrilMS @jennyf19