Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

make L1expirationTime internal for now #1039

Merged
merged 1 commit into from
Mar 3, 2021
Merged

make L1expirationTime internal for now #1039

merged 1 commit into from
Mar 3, 2021

Conversation

jennyf19
Copy link
Collaborator

@jennyf19 jennyf19 commented Mar 3, 2021

No description provided.

@jennyf19 jennyf19 requested a review from jmprieur March 3, 2021 20:36
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 3, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

jmprieur
jmprieur approved these changes Mar 3, 2021
View reviewed changes
Copy link
Collaborator

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

henrik-me
henrik-me approved these changes Mar 3, 2021
View reviewed changes
Copy link
Contributor

@henrik-me henrik-me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jennyf19 jennyf19 merged commit 93839ab into master Mar 3, 2021
@jennyf19 jennyf19 deleted the jennyf/makeL1ExpirePrivate branch March 3, 2021 23:55
This was referenced Mar 12, 2021
Merged
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jmprieur jmprieur jmprieur approved these changes

@henrik-me henrik-me henrik-me approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jennyf19 @jmprieur @henrik-me