[Bug] key _AppTokenCache does not contain ClientId if not set in MicrosoftIdentityOptionss

[jennyf19]

If the ClientId is not set in MicrosoftIdentityOptions, and only in the ConfidentialClientApplicationOptions, then the cache key for the app cache does not contain the Client_id.

Ex:

 services.AddTransient(
_provider => Options.Create(new MicrosoftIdentityOptions
     {
          Authority = TestConstants.AuthorityCommonTenant,
          //ClientId = TestConstants.ConfidentialClientId,
     }));
services.AddTransient(
_provider => Options.Create(new ConfidentialClientApplicationOptions
    {
         Instance = TestConstants.AadInstance,
         TenantId = TestConstants.ConfidentialClientLabTenant,
         ClientId = TestConstants.ConfidentialClientId,
         ClientSecret = _ccaSecret
    }
));

the above will give this key : _AppTokenCache

But this:

 services.AddTransient(
_provider => Options.Create(new MicrosoftIdentityOptions
     {
          Authority = TestConstants.AuthorityCommonTenant,
          ClientId = TestConstants.ConfidentialClientId,
     }));
services.AddTransient(
_provider => Options.Create(new ConfidentialClientApplicationOptions
    {
         Instance = TestConstants.AadInstance,
         TenantId = TestConstants.ConfidentialClientLabTenant,
         ClientSecret = _ccaSecret
    }
));

will give d6921528-eb23-4423-a023-99b1b60f6285_AppTokenCache

[jmprieur]

@jennyf19 proposing to close this one as it won't be necessary any longer when we fix #235.
do you agree?

[jennyf19]

good point. @jmprieur