Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

ezpadova: defaults for AGB + circumstellar dust #258

Open
lcjohnso opened this issue Sep 19, 2018 · 3 comments
Open

ezpadova: defaults for AGB + circumstellar dust #258

lcjohnso opened this issue Sep 19, 2018 · 3 comments

Comments

@lcjohnso
Copy link
Member

I discovered that the default settings for ezpadova are set to:

  1. TP-AGB -- Not resolve thermal pulses (n_inTPC = 0)
  2. M-star Circumstellar Dust -- 60% Silicate + 40% AlOx as in Groenewegen+06 (dust_sourceM = dpmod60alox40)
  3. C-star Circumstellar Dust -- 85% AMC + 15% SiC as in Groenewegen+06 (dust_sourceM = AMCSIC15)

The circumstellar dust only affects the photometry that we ignore, so OK to ignore these for our purposes.

The form's current (v3.0) default parameters are n_inTPC=10 and no circumstellar dust for either M or C-stars. I suggest we adopt these new default choices. Please note that by resolving the TPs, a large number of additional points/samples during the AGB phase, increasing the total samples (and grid size) by ~50%.

Here are a CMD and HR diagram showing the difference between resolution of 0 (big points) and 10 (small points):
tpsampling_hr
tpsampling_cmd

@marthaboyer: do you have an opinion on the TP resolution?

Once decided, I will edit the relevant files and submit a PR.

@karllark
Copy link
Member

This seems reasonable.

@karllark
Copy link
Member

Is there a way to expose these parameters to the BEAST such that if a user wanted more sampling on the TP-AGB and/or circumstellar dust they could indicate this?

@marthaboyer
Copy link
Contributor

Once the AGB atmospheres are in, it makes sense to increase the resolution. And at that point, we probably should set the defaults to some kind of dust, though I'd vote for one of the options from Nanni et al. Or if we leave the default to no dust, then I agree with Karl that we need to expose those parameters.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

3 participants