Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[ISSUE] ExcellentShop prices not being displayed correctly. #4

Open
ItzSave opened this issue Mar 26, 2024 · 8 comments
Open

[ISSUE] ExcellentShop prices not being displayed correctly. #4

ItzSave opened this issue Mar 26, 2024 · 8 comments

Comments

@ItzSave
Copy link

ItzSave commented Mar 26, 2024

When using ExcellentShop v4.8.6 some prices may be off and others will be correct. I have not been able to find a pattern to this but even with the multipliers disabled, it will happen.

Also, the API does not currently detect which version to use I had to manually force it to only use the hook for v4.8+

@OmerBenGera
Copy link
Member

I am using ExcellentShop v4.8.6 and NexEngine 2.2.12 and it seems to work fine for me (at least it picks up the correct provider for ExcellentShop)
What prices exactly are not detected correctly? I'll try replicating it using default config files.

@Istvan474
Copy link

Hi Omer, Save made this issue because it is happening to me using his plugin. Most things are fine and have the actual prices they are supposed to but Carrots are supposed to be 3.6 but is 4.17, leather is supposed to be 5.75 but is 25, wheat supposed to be 3.4 but is 25, Egg supposed to be 1.25 but is 6.25, Spider eye supposed to be 2.75 but is 25. The prices are correct in /shop however in Saves chunk hopper plugin they are messed up like I said above.

@OmerBenGera
Copy link
Member

Hi Omer, Save made this issue because it is happening to me using his plugin. Most things are fine and have the actual prices they are supposed to but Carrots are supposed to be 3.6 but is 4.17, leather is supposed to be 5.75 but is 25, wheat supposed to be 3.4 but is 25, Egg supposed to be 1.25 but is 6.25, Spider eye supposed to be 2.75 but is 25. The prices are correct in /shop however in Saves chunk hopper plugin they are messed up like I said above.

Interesting.
Do you mind sending me a copy of your configuration? I'd like to test it myself as well.

@Istvan474
Copy link

Hi Omer, Save made this issue because it is happening to me using his plugin. Most things are fine and have the actual prices they are supposed to but Carrots are supposed to be 3.6 but is 4.17, leather is supposed to be 5.75 but is 25, wheat supposed to be 3.4 but is 25, Egg supposed to be 1.25 but is 6.25, Spider eye supposed to be 2.75 but is 25. The prices are correct in /shop however in Saves chunk hopper plugin they are messed up like I said above.

Interesting. Do you mind sending me a copy of your configuration? I'd like to test it myself as well.

Which configs do you need? the shop or the chunk collector

@OmerBenGera
Copy link
Member

Hi Omer, Save made this issue because it is happening to me using his plugin. Most things are fine and have the actual prices they are supposed to but Carrots are supposed to be 3.6 but is 4.17, leather is supposed to be 5.75 but is 25, wheat supposed to be 3.4 but is 25, Egg supposed to be 1.25 but is 6.25, Spider eye supposed to be 2.75 but is 25. The prices are correct in /shop however in Saves chunk hopper plugin they are messed up like I said above.

Interesting. Do you mind sending me a copy of your configuration? I'd like to test it myself as well.

Which configs do you need? the shop or the chunk collector

The config files of ExcellentShop
The entire folder if possible.

@Istvan474
Copy link

Sorry for the late reply but here you go!

Hi Omer, Save made this issue because it is happening to me using his plugin. Most things are fine and have the actual prices they are supposed to but Carrots are supposed to be 3.6 but is 4.17, leather is supposed to be 5.75 but is 25, wheat supposed to be 3.4 but is 25, Egg supposed to be 1.25 but is 6.25, Spider eye supposed to be 2.75 but is 25. The prices are correct in /shop however in Saves chunk hopper plugin they are messed up like I said above.

Interesting. Do you mind sending me a copy of your configuration? I'd like to test it myself as well.

Which configs do you need? the shop or the chunk collector

The config files of ExcellentShop The entire folder if possible.

Sorry for the late reply but here you go!
archive-2024-04-06T003219Z.tar.gz

@OmerBenGera
Copy link
Member

OmerBenGera commented Apr 6, 2024

That's really weird, and I suspect it might be something related to your configuration somehow.
When I use /sellhand from ExcellentShop, the spider eye is sold for 50$ from the Traveller Shop. However, when selling from the GUI and I choose the Mob Drops shop, it is sold for 5.5$ (two times then the configured value for mob drops)

I suspect that you have configured spider eye in multiple shops or something, and it just chooses the best price (or first shop that it finds). Contact ExcellentShop for help, they will better be able to help you with that.
( The traveller shop is under the rotating shops)

@OmerBenGera
Copy link
Member

After another look, ShopsBridge did not check for price modifiers of players.
I did update ShopsBridge to support that. However, that only changed the spider eye from being sold for 25$ to 50$, same as it does from /sellhand. It still will detect Traveller as the shop to use and not Mob Drops.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants