Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: Management pages for templates (HEXA-1129, HEXA-1130) #1070

Merged
merged 104 commits into from
Feb 17, 2025
Merged

Conversation

YolanFery
Copy link
Contributor

@YolanFery YolanFery commented Feb 7, 2025

Allow editing and deleting of pipeline templates and versions.

Changes

  • Import the GraphQL schema change from feat: Management pages for templates (HEXA-1129, HEXA-1130) openhexa-app#921
  • Change a bit the Button component to allow more UI customizations
  • Show links to templates in pipeline view
  • Add deep links to the templates view
  • Pages for templates and template versions list
  • Delete template dialog
  • Grid and Card view for templates, user can switch between the two
  • Fix redirections after creation of templates now that we have deep links
  • Update unit tests and extend slightly

How/what to test

  • Create, update, delete template and template versions.
  • The card and grid views are working as expected

Screenshots / screencast

Card view

Screenshot 2025-02-10 at 17 31 09

Card overlay

Screenshot 2025-02-10 at 17 31 35

Template view

Screenshot 2025-02-10 at 17 31 57

Template version view

Screenshot 2025-02-10 at 17 32 08

Template version edit

Screenshot 2025-02-10 at 17 32 14

@YolanFery YolanFery requested a review from qgerome February 15, 2025 09:32
Copy link
Member

@qgerome qgerome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • We can go forward without the split of pages for the pipelines & templates but we'll need to do that right after
  • The sidebar "pipelines" tab is not marked as "active" when the user is in the templates pages.
  • We'll need to fix the pipelines' code problem ASAP

@qgerome
Copy link
Member

qgerome commented Feb 17, 2025

@YolanFery Once you fix the conflict you can merge this.

@YolanFery
Copy link
Contributor Author

  • We can go forward without the split of pages for the pipelines & templates but we'll need to do that right after
  • The sidebar "pipelines" tab is not marked as "active" when the user is in the templates pages.
  • We'll need to fix the pipelines' code problem ASAP

Created two tickets https://bluesquare.atlassian.net/browse/HEXA-1189 and https://bluesquare.atlassian.net/browse/HEXA-1188 to track that and not forget about it 😊

@YolanFery YolanFery merged commit fa58037 into main Feb 17, 2025
3 checks passed
@YolanFery YolanFery deleted the HEXA-1130 branch February 17, 2025 12:41
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants