Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Problem when 2 resolution have the same availableservices selected #116

Closed
saramonzon opened this issue Nov 22, 2022 · 1 comment
Closed

Problem when 2 resolution have the same availableservices selected #116

saramonzon opened this issue Nov 22, 2022 · 1 comment
Assignees
@saramonzon @luissian @svarona
Milestone
v3.0.0

Comments

@saramonzon
Copy link
Member

saramonzon commented Nov 22, 2022 •
edited
Loading

https://github.com/BU-ISCIII/iSkyLIMS/blob/3d2cbbd44edd1b931d9d8cad6d5f1ea448c26ae8/iSkyLIMS_drylab/utils/handling_request_services.py#L544-L546

If two resolutions have the same services selected they are removed in the first resolution so it fails in the next resolution. We need to fix this. Two resolution may have the same services selected.

Trace error:
ValueError at drylab_display_service=2310.pdf
@luissian luissian self-assigned this Nov 22, 2022
@luissian luissian added this to the Release v2.3.1 milestone Nov 22, 2022
@saramonzon saramonzon self-assigned this Feb 15, 2023
@saramonzon saramonzon modified the milestones: Release v2.3.1, v2.3.1 Apr 10, 2023
@luissian
Copy link
Member

solved at PR #137

@saramonzon saramonzon mentioned this issue Oct 17, 2023
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@saramonzon saramonzon

@luissian luissian

@svarona svarona

Labels
None yet
Projects
None yet
Milestone
v3.0.0
Development

No branches or pull requests
3 participants
@saramonzon @luissian @svarona