From b6a7c6f3def532a80c8e703d75a28d2ebd8ad993 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Oskar=20Kwas=CC=81niewski?= Date: Thu, 22 Aug 2024 15:15:51 +0200 Subject: [PATCH 1/2] chore: sync bgfx and bump ios-cmake --- CMakeLists.txt | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index b1cd1915c..84f157b58 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -22,8 +22,8 @@ FetchContent_Declare(base-n GIT_REPOSITORY https://github.com/azawadzki/base-n.git GIT_TAG 7573e77c0b9b0e8a5fb63d96dbde212c921993b4) FetchContent_Declare(bgfx.cmake - GIT_REPOSITORY https://github.com/BabylonJS/bgfx.cmake.git - GIT_TAG 345e3e28a9912983fc64d1dcb4da22a445afe3fd) + GIT_REPOSITORY https://github.com/okwasniewski/bgfx.cmake.git + GIT_TAG 4fb523d2e36d) FetchContent_Declare(CMakeExtensions GIT_REPOSITORY https://github.com/BabylonJS/CMakeExtensions.git GIT_TAG ea28b7689530bfdc4905806f27ecf7e8ed4b5419) @@ -34,7 +34,7 @@ FetchContent_Declare(googletest URL "https://github.com/google/googletest/archive/refs/tags/v1.14.0.tar.gz") FetchContent_Declare(ios-cmake GIT_REPOSITORY https://github.com/leetal/ios-cmake.git - GIT_TAG 4.4.1) + GIT_TAG 4.5.0) FetchContent_Declare(JsRuntimeHost GIT_REPOSITORY https://github.com/BabylonJS/JsRuntimeHost.git GIT_TAG 9ccb9477a97501525f3f9ca0e00e6971934037ec) @@ -141,6 +141,9 @@ if(MSVC) # https://gitlab.kitware.com/cmake/cmake/-/issues/18837 add_compile_options(/Zc:__cplusplus) + # https://devblogs.microsoft.com/cppblog/announcing-full-support-for-a-c-c-conformant-preprocessor-in-msvc/ + add_compile_options(/Zc:preprocessor) + # default to /W3 add_compile_options(/W3) endif() From 4683e94d0c1a57bf54943372000d417def721e85 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Oskar=20Kwas=CC=81niewski?= Date: Fri, 23 Aug 2024 15:49:26 +0200 Subject: [PATCH 2/2] fix: iOS builds, generate only necessary schemes --- Apps/Playground/CMakeLists.txt | 4 ++++ Apps/UnitTests/CMakeLists.txt | 3 ++- CMakeLists.txt | 6 +++--- 3 files changed, 9 insertions(+), 4 deletions(-) diff --git a/Apps/Playground/CMakeLists.txt b/Apps/Playground/CMakeLists.txt index ff4348518..26cb8324e 100644 --- a/Apps/Playground/CMakeLists.txt +++ b/Apps/Playground/CMakeLists.txt @@ -53,6 +53,7 @@ if(APPLE) PRIVATE ${JAVASCRIPTCORE_LIBRARY} PRIVATE NativeCamera) set(RESOURCE_FILES ${STORYBOARD}) + elseif(UNIX) set(SOURCES ${SOURCES} @@ -173,6 +174,8 @@ if(APPLE) FOLDER "Playground") endif() set_property(TARGET Playground PROPERTY UNITY_BUILD false) + set_property(TARGET Playground PROPERTY XCODE_GENERATE_SCHEME YES) + set_property(TARGET Playground PROPERTY XCODE_ATTRIBUTE_CODE_SIGNING_ALLOWED YES) endif() if(WINDOWS_STORE) @@ -205,3 +208,4 @@ source_group(TREE ${CMAKE_CURRENT_SOURCE_DIR} FILES ${REFERENCE_IMAGES}) source_group(TREE ${CMAKE_CURRENT_SOURCE_DIR} FILES ${SCRIPTS}) source_group(TREE ${CMAKE_CURRENT_SOURCE_DIR} FILES ${SOURCES}) set_property(DIRECTORY ${CMAKE_SOURCE_DIR} PROPERTY VS_STARTUP_PROJECT Playground) + diff --git a/Apps/UnitTests/CMakeLists.txt b/Apps/UnitTests/CMakeLists.txt index 2f981dff2..7aa3a5679 100644 --- a/Apps/UnitTests/CMakeLists.txt +++ b/Apps/UnitTests/CMakeLists.txt @@ -60,4 +60,5 @@ endforeach() set_property(TARGET UnitTests PROPERTY FOLDER Apps) source_group(TREE ${CMAKE_CURRENT_SOURCE_DIR} FILES ${SOURCES} ${SCRIPTS}) -source_group(TREE ${CMAKE_CURRENT_SOURCE_DIR}/../node_modules PREFIX node_modules FILES ${EXTERNAL_SCRIPTS}) \ No newline at end of file +source_group(TREE ${CMAKE_CURRENT_SOURCE_DIR}/../node_modules PREFIX node_modules FILES ${EXTERNAL_SCRIPTS}) +set_property(TARGET UnitTests PROPERTY XCODE_GENERATE_SCHEME YES) diff --git a/CMakeLists.txt b/CMakeLists.txt index 84f157b58..8131f7721 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -14,7 +14,7 @@ FetchContent_Declare(AndroidExtensions GIT_TAG 7d88a601fda9892791e7b4e994e375e049615688) FetchContent_Declare(arcana.cpp GIT_REPOSITORY https://github.com/microsoft/arcana.cpp.git - GIT_TAG f2757396e80bc4169f2ddb938ce25367a98ffdd0) + GIT_TAG 1a8a5d6e95413ed14b38a6ac9419048f9a9c8009) FetchContent_Declare(arcore-android-sdk GIT_REPOSITORY https://github.com/google-ar/arcore-android-sdk.git GIT_TAG 98cb803de5482fb2b36effe8be3b5a0d3b726976) @@ -22,8 +22,8 @@ FetchContent_Declare(base-n GIT_REPOSITORY https://github.com/azawadzki/base-n.git GIT_TAG 7573e77c0b9b0e8a5fb63d96dbde212c921993b4) FetchContent_Declare(bgfx.cmake - GIT_REPOSITORY https://github.com/okwasniewski/bgfx.cmake.git - GIT_TAG 4fb523d2e36d) + GIT_REPOSITORY https://github.com/BabylonJS/bgfx.cmake.git + GIT_TAG 17e2f84510dbb69c87a02b08fb11cecb2c4afc9b) FetchContent_Declare(CMakeExtensions GIT_REPOSITORY https://github.com/BabylonJS/CMakeExtensions.git GIT_TAG ea28b7689530bfdc4905806f27ecf7e8ed4b5419)