window.location.href not restored when closing details window

[Zaitsev]

I'm using sectorjs as module in react electron app with hash router
Spector opens results window on capture

window.location.hash === #/anomaly_gl/history which is right hash for captured page
bu after clicking Close hash becomes #/. Since it is react hash router, this renders another page.

[sebavan]

Hello, could you detali a bit more the issue and when this happens ?

thanks,

[Zaitsev]

Just updated issue

[sebavan]

Oh what should the url be to not enter in conflict with yours ???

[Zaitsev]

URL should be the same as it was, btw url by itself is OK, but window.location.hash wes cleared
ie symbols after '#' in hash should not be changed

[sebavan]

Cool thanks.

[Zaitsev]

Offtop: is there any way to move spector to devtools tab like react and redux devtools did it. IMHO spectro IS devtool and having it there will allow to display results in-page and not spoil web-toolbar?

[sebavan]

might be good as an option, I am totally not opposed to it if you fancy doing a PR ?

[Zaitsev]

It would take me too much time (never did any chrome extensions....)

[Zaitsev]

URL should be the same as it was, btw url by itself is OK, but window.location.hash wes cleared
ie symbols after '#' in hash should not be changed

I'm not sure, but if hash is affected then location.search could be affected too , ie ?param1=val&param2=val2 part of uri

[sebavan]

Ok I ll try to do the url changes soon and keep the other one for later as a feature request. I won t be available before monday next week though when I should do the logo migration as well.