Skip to content

disableVertexAttribArray input interpreted incorrectly #55

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
juj opened this issue Aug 10, 2017 · 3 comments · Fixed by #134
Closed

disableVertexAttribArray input interpreted incorrectly #55

juj opened this issue Aug 10, 2017 · 3 comments · Fixed by #134
Assignees
@sebavan
Labels
bug
Milestone
Version 0.9

Comments

@juj
Copy link
Contributor

juj commented Aug 10, 2017

It looks like the index parameter in calls to GL.disableVertexAttribArray(index) is incorrectly interpreted as an enum for GL.drawArrays primitive type. See the following screenshot:

10kcubes

which reads

disableVertexAttribArray: TRIANGLES
disableVertexAttribArray: TRIANGLE_STRIP

whereas it should read

disableVertexAttribArray: 4
disableVertexAttribArray: 5
@juj
Copy link
Contributor Author

juj commented Aug 10, 2017

It looks like enableVertexAttribArray has the same behavior, though some indices some out properly as numbers, only others get the number mistranslated to an enum name.

@sebavan
Copy link
Member

sebavan commented Aug 10, 2017

I ll fix it ASAP

@sebavan sebavan self-assigned this Aug 10, 2017
@sebavan sebavan added the bug label Aug 10, 2017
@sebavan sebavan added this to the Version 0.9 milestone Aug 10, 2017
@sebavan
Copy link
Member

sebavan commented Aug 12, 2017

Fixed by fd0080c

@sebavan sebavan closed this as completed Aug 12, 2017
@xsbchen xsbchen mentioned this issue Jan 9, 2020
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@sebavan sebavan

Labels
bug
Projects
None yet
Milestone
Version 0.9
Development

Successfully merging a pull request may close this issue.

Fixed: EnableDisableVertexAttrib command format xsbchen/Spector.js
2 participants
@juj @sebavan