Skip to content

Manually serialize and deserialize the canvas capture to/from JSON and #71

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Oct 20, 2017

Conversation

kenrussell
Copy link
Contributor

split it into chunks in order to work around new message size limits
imposed in Chrome.

Fixes #69.

split it into chunks in order to work around new message size limits
imposed in Chrome.

Fixes BabylonJS#69.
@kenrussell
Copy link
Contributor Author

Note: tested by running the extension against https://webglsamples.org/aquarium/aquarium.html with the default number of fish. Crashes in Chrome Canary without this fix, works with it. Also tested a few of the other SpectorJS demos; they all work.

Also tried https://s3.amazonaws.com/mozilla-games/ZenGarden/EpicZenGarden.html , but when SpectorJS attempts to capture a frame of that demo, it still crashes the renderer process with an out-of-memory error. The new behavior's no worse than the previous behavior, though SpectorJS used to work against this demo and it would be great if we could get it working again by reducing its memory consumption.

@sebavan sebavan merged commit c8cdeaf into BabylonJS:master Oct 20, 2017
@sebavan
Copy link
Member

sebavan commented Oct 20, 2017

Thanks a lot !!!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants