Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

A little suggest about supporting Windows system commands #394

Open
zhaoxiujie opened this issue Mar 14, 2024 · 0 comments
Open

A little suggest about supporting Windows system commands #394

zhaoxiujie opened this issue Mar 14, 2024 · 0 comments

Comments

@zhaoxiujie
Copy link

zhaoxiujie commented Mar 14, 2024

My OS is Windows. I need to debug my program locally. But this tool doesn't seem to support executing Windows system commands such as 'dir' ,'chdir' ,etc. So I have to manually modify the following code:
diff_cover/command_runner.py # execute() line:27
process = subprocess.Popen(command, stdout=stdout_pipe, stderr=stdout_pipe)
to
process = subprocess.Popen(command, stdout=stdout_pipe, stderr=stdout_pipe,shell=True,cwd=None)

So I suggest to add the 'shell' and 'cwd' parameters when using the class Popen.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant