Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Contacts search is erroneously case-sensitive #223

Open
bam80 opened this issue Jan 30, 2023 · 5 comments
Open

Contacts search is erroneously case-sensitive #223

bam80 opened this issue Jan 30, 2023 · 5 comments

Comments

@bam80
Copy link

bam80 commented Jan 30, 2023

I think Contacts search should be case-insensitive for sure.
It's not obvious if it's not, error-prone, confusing and has no point. No other apps have this search as case-sensitive.

I couldn't find some my contacts for a long time, until I realized occasionally it was because of the case.

@Viish
Copy link
Member

Viish commented Jan 30, 2023

Search in contacts fragment of linphone-android is already case insensitive.

@Viish Viish closed this as not planned Won't fix, can't repro, duplicate, stale Jan 30, 2023
@bam80
Copy link
Author

bam80 commented Jan 30, 2023

I retested it and apparently the case in-sensitiveness is only spans for English names, indeed.
For e.g. Russian, it goes case-sensitive, still.

@Viish Viish reopened this Jan 30, 2023
@Viish Viish transferred this issue from BelledonneCommunications/linphone-android Jan 30, 2023
@Viish
Copy link
Member

Viish commented Jan 30, 2023

@julonexus What do you think?

@ghost
Copy link

ghost commented Jan 30, 2023

The main issue from insensitive search is that tolower (for example) doesn't work well with non wide characters (string / wstring).
liblinphone do the search on string so it can an issue.
On Desktop, we are using the insensitve search on QString (which is UTF16, so I guess it should not be an issue) for search contacts.
But results from smartsearchbar are done from liblinphone. It could be a good way to check on these results.

@bam80
Copy link
Author

bam80 commented Feb 12, 2023

Is there any plan how to fix it?
Port liblinphone to wstring?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants