Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Project 2 spec, Gitlet merge command #4

Open
GuardianWang opened this issue Jul 6, 2021 · 0 comments
Open

Project 2 spec, Gitlet merge command #4

GuardianWang opened this issue Jul 6, 2021 · 0 comments

Comments

@GuardianWang
Copy link

Hi CS61B Contributors,

I am from Brown and during this summer, I'm studying Java with this excellent course. Recently I'm doing project 2 Gitlet. The description of merge command says

If the split point is the current branch, then the effect is to check out the given branch.

However, it would be better if the difference between merge with a fast-forward current branch and checkout is further clarified. When merging in this condition,

  • the current branch is still the previous branch, and
  • the branch head will points at the other branch.

For example, if we are at branch master and HEAD points to commit c1. Branch other points to commit c2.

                        *master     other
*------------*------------*------------*
                         c1           c2

After merge other, the status is expected to be

                                     *master
                                      other
*------------*------------*------------*
                         c1           c2

However, if we only checkout other, then the status is

                        master     *other
*------------*------------*------------*
                         c1           c2

I'm not sure about the details about your autograder, but I believe it's better to add more clarification in the spec.

Thanks a lot.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant