-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Wk v3.1.30 qa fix #1203
Draft
wkelly17
wants to merge
45
commits into
dev
Choose a base branch
from
wk-v3.1.30-qa-fix
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Wk v3.1.30 qa fix #1203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n build to accoutn for manual invocation
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes 2 unrelated bugs, and adds 2 small features. It's not much code at all, but it was enough of a headache for me that I'm going to leave a record here of what left me confused for quite a while on this stuff.
Problem 1
Why:
When we changed to signing the Mac app, install4j enables the hardened runtime. This is completely separate and different from sandboxing. There are two similar but slightly different permissions for sandboxes vs the hardened runtime.
See: https://stackoverflow.com/questions/49595811/macos-entitlements-audio-input-vs-microphone
In our case, when Dan had added com.apple.security.device.microphone, it worked, but now no longer did since singing enable the runtime.
Solution:
You'll notice there is now a
entitlements-dmg.plist file and a entitlements.plist. This is due to the fact that the sandbox needs some additional permissions, such as both audio entitlements and team identifier stuff related to signing.
To Test:
A fresh install of the normal mac dmg job should prompt you for mic permission.
Problem 2.
Tests were passing, Code was successfully being notarized when you checked the cert chain and signature, BUT upon running Orature, app store builds crashed immediately.
Why:
Solution
Mostly, just read this: https://groups.google.com/g/jna-users/c/Bws1h060faA?pli=1
-Dorg.sqlite.lib.name=libsqlitejdbc.dylib, -Djna.nounpack=true, -Djna.nosys=true, -Djna.boot.library.path=${installer:sys.contentDir}/mac/x86_64:${installer:sys.contentDir}/mac/aarch64
These are passed Only for the MacOs launcher for pkg files. Every other target is still the same.
Feature
In the dedicated mac pkg build, I added a workflow parameter that allow you to build a dev version of the pkg file. You can't install pkg's outside of app store if they are signed with distribution certificates, so you have to sign with a different set of keys for local testing of a pkg file (i.e. this cert has device ids for Joe, Max, and David). This is slightly less of an issue because feature 2
You'll see that the install4j version bumped to 11.02. This fixes a proble that was being had where install4j uses the VERSION for the id that apple uses to bump versions in the app store. Now you can keep the marketing version the same, and it uses a timestamp under the hood so that you can test builds through testflight without incrementing the software version number.
Lmk if you have any questions
This change is