Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Test including discvr-components as a dependency of DiscvrLabkeyModules #14

Open
hextraza opened this issue Jun 10, 2024 · 1 comment
Open
Assignees

Comments

@hextraza
Copy link
Contributor

hextraza commented Jun 10, 2024

The new ValueComponent in discvr-components is roughly equivalent to a portion of the DiscvrLabkeyModules FilterForm. This comprises quite a bit of JSX and a couple JS callback handlers listed at the top of FilterForm.

We should be able to remove the relevant portion of FilterForm and replace it with a single call to the ValueComponent. Create a new branch and install discvr-components as a dependency, and then perform this refactor. The FilterForm in DiscvrLabkeyModules should act exactly the same as it previously did, and all selenium tests should pass.

The variant search table that contains the FilterForm is accessible by going to http://localhost:8080/labkey/JBrowseVerifyProject/project-begin.view?pageId=overview -> clicking the number next to "JBrowse Sessions" -> View in JBrowse -> Open -> Open Track Selector -> checking TestVCF -> on the new TestVCF panel that opens on the left-hand side, click the three-dot menu -> Variant Search.

The FilterForm is the menu that pops up when you click Search. The ValueComponent is that right-hand-side input, which changes depending on other stuff you do in the form, i.e. operator type.

@hextraza
Copy link
Contributor Author

hextraza commented Jun 17, 2024

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants