Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remux WebM to MP4 #3092

Closed
ProtagNeptune opened this issue Jan 27, 2024 · 3 comments
Closed

Remux WebM to MP4 #3092

ProtagNeptune opened this issue Jan 27, 2024 · 3 comments
Assignees
Milestone

Comments

@ProtagNeptune
Copy link
Sponsor

ProtagNeptune commented Jan 27, 2024

Maybe add the option "Remux WebM to MP4" in the Filename below "Replace JPEG by JPG"?
image
https://stackoverflow.com/questions/18123376/webm-to-mp4-conversion-using-ffmpeg/60443156#60443156

This will also solve ExifTool being incompatible with WebM for adding metadata to the downloaded videos in Grabber.

@Bionus Bionus self-assigned this Jan 29, 2024
@Bionus Bionus added this to the 7.12.0 milestone Jan 29, 2024
@Bionus
Copy link
Owner

Bionus commented Jan 29, 2024

Just pushed a commit to implement this. The setting is in "Save > Format conversion" and requires ffmpeg to be present somewhere in the PATH where Grabber can find it.

image

Note that it has one drawback however: the files will be properly detected if you use a MD5 list, as the remuxed path will be stored in the MD5 database, but they won't be found without it. Because if you use %ext% to check if the image exists on the disk, it will search for "webm" files, but those won't exist. Working around this would be a quite extensive change, so for now I believe it should be fine.

@ProtagNeptune
Copy link
Sponsor Author

ProtagNeptune commented Jan 30, 2024

Just pushed a commit to implement this. The setting is in "Save > Format conversion" and requires ffmpeg to be present somewhere in the PATH where Grabber can find it.

I'm wondering if this happens before applying metadata.
So that ExifTool can apply the metadata to the remuxed mp4?

@ProtagNeptune
Copy link
Sponsor Author

ProtagNeptune commented Jan 30, 2024

Note that it has one drawback however: the files will be properly detected if you use a MD5 list, as the remuxed path will be stored in the MD5 database, but they won't be found without it. Because if you use %ext% to check if the image exists on the disk, it will search for "webm" files, but those won't exist. Working around this would be a quite extensive change, so for now I believe it should be fine.

Maybe add a flag or something in the MD5 database that this file has "convert" to "mp4"?
So that when searching for it, it finds the "webm" file with the "convert" flag set to "mp4" so it checks if there's an mp4 of that file.
You might also add the "origin" flag with "webm" for example in case you need it.

@Bionus Bionus modified the milestones: 7.13.0, 7.12.0 May 12, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

2 participants