Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Track spending transactions in database #24

Open
theanmolsharma opened this issue Jan 27, 2024 · 4 comments
Open

Track spending transactions in database #24

theanmolsharma opened this issue Jan 27, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@theanmolsharma
Copy link
Collaborator

In the current implementation, we don't save the transactions where we spend from our wallet. We should probably start doing that by making a function that allows users to list/track such transactions.

Implementation details are still not clear in my head right now but we can use this issue to discuss them.

@theanmolsharma theanmolsharma added the enhancement New feature or request label Jan 27, 2024
@emjshrx
Copy link
Contributor

emjshrx commented Feb 10, 2024

saveSpendTransaction(txId:string,label:string)
getSpendTransactions():Record<string,string>[]

We can get transaction details if needed from txId from the network?

@Ayush170-Future
Copy link
Contributor

Hey @emjshrx,

Could you provide me with some ideas on how to begin with this issue? Should these functions be created in the WalletDB (Level DB)? I'm a little confused about the part regarding saving the transactions where we spend from our wallet. Aren't all transactions spent from our wallet? Or is this something specific to BIP 352, meaning I have to read it completely?

Just tell me something, so that I can start in the right direction.

@emjshrx
Copy link
Contributor

emjshrx commented Mar 3, 2024

This issue hasnt been discussed to its fullest and actually might not be needed for our PoC. Lets discuss in this weeks call. cc @theanmolsharma

@aruokhai
Copy link

Any update regarding this ?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants