Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

PR Review Club : Settxfeerate #91

Open
Prabhat1308 opened this issue Nov 16, 2024 · 0 comments
Open

PR Review Club : Settxfeerate #91

Prabhat1308 opened this issue Nov 16, 2024 · 0 comments

Comments

@Prabhat1308
Copy link

Session Details

Date: 21-11-2024
Time: IST 20:00 (UTC 14:30)
Link: PR #30886
Difficulty: Medium

Motivation:

New RPC call settxfeerate is added. It does the same as the actual settxfee but takes the feerate in sat/vB instead of B/kvB.

settxfee still available but hidden so we avoid incompatibility problems with applications that use that RPC call.
When deprecation is desired, the process should be as simple as just delete settxfee RPC call function and correct the tests where it is called.

Questions:

TBD

Learnings:

RPC
Wallet

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant