Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Some exogenous processes use timesteps and some use l1 blocks, probably good to standardize #283

Closed
SeanMcOwen opened this issue May 13, 2024 · 5 comments · Fixed by #312
Labels

Comments

@SeanMcOwen
Copy link
Contributor

I.e. check_for_censorship uses time_l1 versus #275

@SeanMcOwen SeanMcOwen added Tier1 question Further information is requested labels May 13, 2024
@jackhack00
Copy link
Contributor

agreed, but might want to discuss to make sure
iirc there was some trip up as we don't have equal timesteps and l1blocks (since we sometimes fastforward)

@SeanMcOwen
Copy link
Contributor Author

Switch to L1 blocks

@SeanMcOwen SeanMcOwen removed the question Further information is requested label May 22, 2024
@SeanMcOwen
Copy link
Contributor Author

Spawning a tier3 issue to do a more rigorous testing to make sure everything is aligned with L1 blocks, i.e. make sure no exogenous series would now break: #313

@SeanMcOwen
Copy link
Contributor Author

SeanMcOwen commented May 22, 2024

  • Switch value_from_param_timeseries_suf to use l1
  • Check all other places timestep is called
  • steady_state_l1_gas_estimate
  • steady_state_blob_gas_estimate

@SeanMcOwen
Copy link
Contributor Author

Also spawns this tier 5: #314

@SeanMcOwen SeanMcOwen linked a pull request May 22, 2024 that will close this issue
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants