fix(uninstaller): fixed losing root access #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #6
由于在
uninstall.sh中使用了su命令，这似乎会导致模块被卸载后导致root权限丢失而由于Magisk模块在卸载过程中的限制，无法对应用数据目录进行操作，从而导致卸载模块并恢复文件时失效
使用音量键选择运行模式的方式，将卸载模块的方式将操作整合到安装模块的过程中，从而修复备份与恢复文件的功能
在Google Pixel 4XL，Android13、Magisk Delta(Cannary) 0fe46c5a-delta(26301)中完成测试