Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

BUG: exclude-file-type=yml doesnt ignore yaml files and vice-versa. #214

Open
gurukiran07 opened this issue Oct 28, 2024 · 2 comments
Open
Labels
bug Something isn't working has-pr This issue has an associated PR help wanted Extra attention is needed validator-core Issues that relate to the core validator functionality

Comments

@gurukiran07
Copy link
Contributor

validator --exclude-file-types=yml doesnt exclude .yaml. It only excludes yml files.

Expected output: To be able to exclude files both yaml and yml when given one of them as argument to exclude-file-type.

@gurukiran07 gurukiran07 changed the title exclude-file-type=yml doesnt ignore yaml files and vice-versa. BUG: exclude-file-type=yml doesnt ignore yaml files and vice-versa. Oct 28, 2024
@ccoVeille
Copy link
Contributor

I had to read it twice

It differs from

It completes it, as it's different

I agree with you, the fact we ask to exclude a file types should exclude everything

Maybe we should add an field on the filetype to list the known named, or the additional and optional aliases for a file type

This way, you would use Name, not extension, then you would exclude the file with the extension of the file type.

@kehoecj
Copy link
Collaborator

kehoecj commented Oct 30, 2024

Yeah we should definitely fix this. I agree with @ccoVeille on this assessment:

Maybe we should add an field on the filetype to list the known named, or the additional and optional aliases for a file type

@kehoecj kehoecj added bug Something isn't working help wanted Extra attention is needed validator-core Issues that relate to the core validator functionality labels Oct 30, 2024
@kehoecj kehoecj added the has-pr This issue has an associated PR label Nov 11, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working has-pr This issue has an associated PR help wanted Extra attention is needed validator-core Issues that relate to the core validator functionality
Projects
None yet
Development

No branches or pull requests

3 participants