Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Crio - Second header menu dropdown overlaps text link on mobile #150

Closed
nicolepaschen opened this issue Jan 10, 2020 · 2 comments · Fixed by #169
Closed

Crio - Second header menu dropdown overlaps text link on mobile #150

nicolepaschen opened this issue Jan 10, 2020 · 2 comments · Fixed by #169
Labels
bug General bug issues

Comments

@nicolepaschen
Copy link
Member

I have two menus in the header. On mobile, the secondary menu dropdown has a + sign but it overlaps the text.

two-menus

@timelsass
Copy link
Member

that one is tricky. the main reason this is lthis way is because of social media icon menus where the desired appearance is inline next to each other for each icon. Changing dropdowns in this situation and making the menu items appear full width isn't difficult, but would cause social media icon menus to then be vertical on mobile. If you add the hamburger to the location, then it will display as the main menu location does where there's no overlap and veritical. I think the only solution to have it both ways would be to introduce a new control here where a user can opt for inline display, and in this case - I think we would then want to flatten dropdowns completely so inline display menus don't offer dropdowns. This is currently possible via the configs, but there's not any direct controls or code to handle it for a user. Having the ability to do the hamburger all the time we discussed previously would probably tie in as a nice feature that would go along with implementing this feature. For design purposes, just setting the li to 100% width via css would probably do what you need, but is less than ideal for users in general:

#secondary-wrap .sm li {
    width: 100%;
}

@rramo012 rramo012 added the bug General bug issues label Mar 11, 2020
@nicolepaschen
Copy link
Member Author

Cannot replicate closing

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug General bug issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants