Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[FEATURE] Select primary / secondary button design from Customizer #507

Closed
nicolepaschen opened this issue Sep 28, 2021 · 11 comments
Closed
Labels
Milestone

Comments

@nicolepaschen
Copy link
Member

Right now all theme designs have the same button style from the config. It would be helpful if there was a panel in the Customizer that showed all buttons available from the PPB for the user to select their own primary / secondary styles.

This would also help stop all the sites from looking the same.

@nicolepaschen
Copy link
Member Author

Also need transparent buttons

@jamesros161 jamesros161 added this to the Stable milestone Dec 9, 2021
@nicolepaschen
Copy link
Member Author

Beta 1 - I cannot add a border to a button as expected:
buttons

@nicolepaschen
Copy link
Member Author

Beta 1 - Primary button de# PPB popover doesn't match what is set in Customizer:
primary-design-panel

@nicolepaschen
Copy link
Member Author

Beta 1 - I cannot style the secondary button with the first palette position or transparent:
secondary-button

@nicolepaschen
Copy link
Member Author

Beta 1 - designs are not carrying thru to the Blog Page Designs. The font did but not the style (pill)

@nicolepaschen
Copy link
Member Author

Button designs should NOT affect submit buttons please

@jamesros161
Copy link
Contributor

It looks like most of these issues are due to an update not being pushed correctly to the dependant repo https://github.com/BoldGrid/Buttons

The primary button not showing in the PPB popover is a separate issue, and will be addressed in a different ticket

@nicolepaschen
Copy link
Member Author

nicolepaschen commented Jan 18, 2022

RC1 - The primary button style only shows when the Customizer is open. I have it set to pill with a thick border:

buttons

PPB doesn't show the correct primary style either:
image

@nicolepaschen
Copy link
Member Author

nicolepaschen commented Jan 19, 2022

Transparent button text should match border.

I cannot change the color of button text in the PPB as expected:
button-text-color-override

@nicolepaschen
Copy link
Member Author

Default button Font Family should match Main Text - right now they're all Roboto

@jamesros161
Copy link
Contributor

jamesros161 commented Jan 19, 2022

  1. I don't see a hover effect at the moment on the front end
  2. Default font family should match main text
  3. Default font color for transparent buttons should match border
  4. I cannot change the color of button text in the PPB as expected

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants