Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Support Grammarly #1421

Closed
nmehlei opened this issue May 7, 2019 · 2 comments
Closed

Support Grammarly #1421

nmehlei opened this issue May 7, 2019 · 2 comments

Comments

@nmehlei
Copy link

nmehlei commented May 7, 2019

Describe the feature you'd like
I'm using Grammarly constantly in my daily work. Grammarly is a really nice and useful browser plugin to help people like me who are not native to English to fix a lot of common mistakes while typing. As is usual with spell correction, errors are marked in red. Unfortunately, when using the editor of BookStack, those red markings are then somehow persistently saved in the saved content. Probably BookStack just stores the displayed HTML back again as it doesn't expect for external processes to change it. I disabled Grammarly for my BookStack wiki but as wikis are very text-intensive Grammarly would be even more important for a wiki than for most of the remaining internet.

Describe the benefits this feature would bring to BookStack users
The benefit would be to allow great spell checking and correction for an application that is almost completely text-centric.

IF it is not the developers wish to support Grammarly then this problem can be partially avoided with adding a "data-gramm" attribute to disable Grammarly's spell checking, thus a user does not have to put it manually in an ignore list. But obviously support would be the better solution ;)

Additional context
While writing this entry I found slab/quill#574 , which might contain a (partial) solution but I didn't have the time to understand it completely.

@nmehlei
Copy link
Author

nmehlei commented May 8, 2019

I've re-enabled Grammarly yesterday and as of now, I did not notice any invalidly saved content. Not sure if this was either resolved by accident (by either BookStack or the Grammarly chrome plugin) or if it just occurs in specific cases. I'll add to this issue if I can isolate it more.

@ssddanbrown
Copy link
Member

Since I do not intend to specifically support Grammarly and since this was not followed-up as an issue I'll close this off.

Thanks still @nmehlei for the detail in your original request.

# for free to join this conversation on GitHub. Already have an account? # to comment
Development

No branches or pull requests

2 participants